compiler: Add Windows resources to rustc-main and rustc_driver #146018

lambdageek · 2025-08-29T21:52:55Z

Adds Windows resources with the rust version information to rustc-main.exe and rustc_driver.dll

Invokes rc.exe directly, rather than using one of the crates from the ecosystem to avoid adding dependencies.

A new internal rustc_windows_rc crate has the common build script machinery for locating rc.exe and constructing the resource script

rustbot · 2025-08-29T21:52:59Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-08-29T21:53:02Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

bjorn3 · 2025-08-29T22:01:28Z

Why is the rustc version included in the product name? At most including the release channel would make sense to me (given that nightly genuinely behaves differently from stable by allowing unstable features), but the exaxt version is duplicated with the product version field.

lambdageek · 2025-08-29T22:39:12Z

Why is the rustc version included in the product name?

I don't have a good justification for the first iteration of this PR. Happy to update the names/descriptions to whatever makes the most sense

rustbot · 2025-08-29T23:28:14Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

lambdageek · 2025-08-29T23:45:04Z

Updated the Product Description to be just "Rust Compiler" or "Rust Compiler (channel)" for non-stable

jieyouxu · 2025-08-30T02:50:00Z

This needs someone who actually have some clues about windows resources to review... I'll ask about a reviewer

jieyouxu · 2025-08-30T02:52:19Z

Adds Windows resources with the rust version information to rustc-main.exe and rustc_driver.dll

I'm not familiar with Windows resources. But can you say more on the motivation for this change?

EDIT: okay I found #t-compiler/windows > version resources on rustc.exe and rustc_driver.dll, but it's still not super obvious to me the motivation for the change.

lambdageek · 2025-08-30T03:20:49Z

In many ways this is a cosmetic change: as you can see in the screenshot in the comment above, Windows shows the version info in the file explorer when you right click on the .exe or .dll and look at the details

However this info is also used by some other tools on Windows such as debuggers or crash reporters when collecting diagnostic information.

For our internal builds of Rust at Microsoft having version info available would allow us to collect better automated crash reports from our users.
I could just add this only in our internal builds, but it seemed like it would be useful to upstream it.

jieyouxu · 2025-08-30T03:24:06Z

Ok thanks for the clarification, that makes sense. I'll ask internally for another reviewer who has at least slightly more clues about this than I do.

compiler/rustc_windows_rc/src/lib.rs

rustbot · 2025-09-03T01:02:24Z

wesleywiser is currently at their maximum review capacity.
They may take a while to respond.

mati865 · 2025-09-04T07:33:54Z

add the support for windows-gnu (I'm not sure if this one is going to work) and windows-gnullvm

@mati865 you would need to use the windres resource compiler from the GNU toolchain. the .rc file format is the same. If you specify the output format as -O coff I think you should be able to just pass the result to the gnu linker (ie, I don't think the stuff in rustc_driver and rustc_main build scripts would need to change much).

I know, it's just not a priority for me.
With LD there might be a clash with default-manifest.o that is provided by default. Unlike LLVM tools, LD still cannot properly handle multiple resource files.

compiler/rustc_windows_rc/rustc.rc.in

wesleywiser

lgtm can you squash your commits together and force push?

View changes since this review

Adds Windows resources with the rust version information to rustc-main.exe and rustc_driver.dll Sets the product description to "Rust Compiler" or "Rust Compiler (channel)" for non-stable channels

lambdageek · 2025-09-05T18:08:01Z

@wesleywiser done

wesleywiser · 2025-09-08T14:42:35Z

@bors r+

bors · 2025-09-08T14:42:38Z

📌 Commit 095fa86 has been approved by wesleywiser

It is now in the queue for this repository.

…esleywiser compiler: Add Windows resources to rustc-main and rustc_driver Adds Windows resources with the rust version information to rustc-main.exe and rustc_driver.dll Invokes `rc.exe` directly, rather than using one of the crates from the ecosystem to avoid adding dependencies. A new internal `rustc_windows_rc` crate has the common build script machinery for locating `rc.exe` and constructing the resource script

Rollup of 11 pull requests Successful merges: - #145177 (std: move `thread` into `sys`) - #146018 (compiler: Add Windows resources to rustc-main and rustc_driver) - #146025 (compiler: Include span of too huge array with `-Cdebuginfo=2`) - #146184 (In the rustc_llvm build script, don't consider arm64* to be 32-bit) - #146195 (fix partial urlencoded link support) - #146300 (Implement `Sum` and `Product` for `f16` and `f128`.) - #146314 (mark `format_args_nl!` as `#[doc(hidden)]`) - #146324 (const-eval: disable pointer fragment support) - #146326 (simplify the declaration of the legacy integer modules (`std::u32` etc.)) - #146339 (Update books) - #146343 (Weakly export `platform_version` symbols) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-09-09T03:56:44Z

⌛ Testing commit 095fa86 with merge fefce3c...

bors · 2025-09-09T07:07:04Z

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing fefce3c to master...

github-actions · 2025-09-09T07:10:19Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e9b6085 (parent) -> fefce3c (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard fefce3cecd63cebf2d7c9aa3dd90a84379fcfa1a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 3117.2s -> 5295.3s (69.9%)
dist-x86_64-apple: 5617.0s -> 9013.2s (60.5%)
pr-check-1: 1732.5s -> 1359.0s (-21.6%)
dist-various-1: 3738.0s -> 4319.2s (15.6%)
aarch64-gnu-llvm-19-1: 3894.5s -> 3340.1s (-14.2%)
i686-gnu-2: 6412.3s -> 5517.5s (-14.0%)
aarch64-gnu-llvm-19-2: 2591.1s -> 2245.5s (-13.3%)
x86_64-gnu-llvm-19-1: 3626.7s -> 3232.3s (-10.9%)
x86_64-gnu-miri: 4931.9s -> 4410.0s (-10.6%)
i686-gnu-1: 8272.1s -> 7423.4s (-10.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-09T09:24:22Z

Finished benchmarking commit (fefce3c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.8%	[3.8%, 3.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 466.867s -> 467.971s (0.24%)
Artifact size: 387.52 MiB -> 387.55 MiB (0.01%)

nico · 2025-09-11T13:06:05Z

Hardcoding rc.exe instead of allowing llvm-rc or some other res-writing crate prevents cross-building rustc-for-Windows on non-Windows hosts, no?

ilovepi · 2025-09-11T23:37:15Z

Hardcoding rc.exe instead of allowing llvm-rc or some other res-writing crate prevents cross-building rustc-for-Windows on non-Windows hosts, no?

Yeah this is also a problem for builds of Fuchsia's toolchains. Is there some way we can specify the path to the build directly? Maybe via the config.toml? Or an environment variable?

rustbot assigned jieyouxu Aug 29, 2025

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 29, 2025

lambdageek force-pushed the add-winres-version branch from 92170d4 to 6886e5b Compare August 29, 2025 23:28

lambdageek force-pushed the add-winres-version branch from 4cdb255 to a21db62 Compare August 29, 2025 23:44

This comment has been minimized.

Sign in to view

rustbot assigned ChrisDenton Aug 30, 2025

This comment has been minimized.

Sign in to view

rustbot unassigned jieyouxu Aug 30, 2025

jieyouxu added the O-windows Operating system: Windows label Aug 30, 2025

jieyouxu assigned jieyouxu and unassigned ChrisDenton Aug 30, 2025

hkBst reviewed Aug 30, 2025

View reviewed changes

compiler/rustc_windows_rc/src/lib.rs Outdated Show resolved Hide resolved

hkBst reviewed Aug 30, 2025

View reviewed changes

compiler/rustc_windows_rc/src/lib.rs Outdated Show resolved Hide resolved

hkBst reviewed Aug 30, 2025

View reviewed changes

compiler/rustc_windows_rc/src/lib.rs Outdated Show resolved Hide resolved

hkBst reviewed Aug 30, 2025

View reviewed changes

compiler/rustc_windows_rc/src/lib.rs Outdated Show resolved Hide resolved

rustbot assigned wesleywiser and unassigned jieyouxu Sep 3, 2025

lambdageek mentioned this pull request Sep 4, 2025

find-msvc-tools: consider adding a public function to find Windows SDK tools rust-lang/cc-rs#1545

Closed

wesleywiser reviewed Sep 4, 2025

View reviewed changes

compiler/rustc_windows_rc/rustc.rc.in Show resolved Hide resolved

wesleywiser approved these changes Sep 5, 2025

View reviewed changes

compiler: Add Windows resources to rustc-main and rustc_driver

095fa86

Adds Windows resources with the rust version information to rustc-main.exe and rustc_driver.dll Sets the product description to "Rust Compiler" or "Rust Compiler (channel)" for non-stable channels

lambdageek force-pushed the add-winres-version branch from 5e579f4 to 095fa86 Compare September 5, 2025 18:07

wesleywiser approved these changes Sep 8, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2025

jhpratt mentioned this pull request Sep 8, 2025

Rollup of 11 pull requests #146351

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 9, 2025

bors merged commit fefce3c into rust-lang:master Sep 9, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Sep 9, 2025

lambdageek deleted the add-winres-version branch September 9, 2025 07:35

bors mentioned this pull request Sep 9, 2025

Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools #146186

Draft

github-actions bot mentioned this pull request Sep 10, 2025

Toolchain upgrade to nightly-2025-09-11 flux-rs/flux#1271

Draft

compiler: Add Windows resources to rustc-main and rustc_driver #146018

compiler: Add Windows resources to rustc-main and rustc_driver #146018

Conversation

lambdageek commented Aug 29, 2025

Uh oh!

rustbot commented Aug 29, 2025

Uh oh!

rustbot commented Aug 29, 2025

Uh oh!

This comment was marked as outdated.

bjorn3 commented Aug 29, 2025

Uh oh!

This comment has been minimized.

lambdageek commented Aug 29, 2025

Uh oh!

rustbot commented Aug 29, 2025

Uh oh!

lambdageek commented Aug 29, 2025

Uh oh!

This comment has been minimized.

jieyouxu commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

jieyouxu commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lambdageek commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Aug 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Sep 3, 2025

Uh oh!

mati865 commented Sep 4, 2025

Uh oh!

Uh oh!

wesleywiser left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lambdageek commented Sep 5, 2025

Uh oh!

wesleywiser commented Sep 8, 2025

Uh oh!

bors commented Sep 8, 2025

Uh oh!

bors commented Sep 9, 2025

Uh oh!

bors commented Sep 9, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 9, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Sep 9, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

nico commented Sep 11, 2025

Uh oh!

ilovepi commented Sep 11, 2025

Uh oh!

Uh oh!

jieyouxu commented Aug 30, 2025 •

edited

Loading

jieyouxu commented Aug 30, 2025 •

edited

Loading

lambdageek commented Aug 30, 2025 •

edited

Loading

wesleywiser left a comment •

edited by rustbot

Loading